Refactor request execution and use IPLD SkipMe functionality for proper partial results on a request #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribasushi
approved these changes
Jun 29, 2020
Comment on lines
-443
to
+431
| selector, err := ipldutil.ParseSelector(selectorSpec) | ||
| _, err = ipldutil.ParseSelector(selectorSpec) | ||
| if err != nil { | ||
| return gsmsg.GraphSyncRequest{}, hooks.RequestResult{}, nil, err | ||
| return gsmsg.GraphSyncRequest{}, hooks.RequestResult{}, err |
There was a problem hiding this comment.
Looks great! my only nit would be that I'd rewire this error check into an inlined version. Otherwise it seems like .ParseSelector has side-effects ( also do you even need to check .EncodeNode above? )
There was a problem hiding this comment.
oh shoot. just realized what you're saying. will fix in later PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
In preparation for adding pause/resume to the request side of graphsync, refactor some code into a request "executor module". Also properly implement skipping parts of the tree that are missing -- at the time we originally wrote graphsync, IPLD selectors had not abilty to "skip" on block load errors but now they have this ability.
Implementation